valkyrjaio / valkyrja-php / 30726116251

100%

push

github

[Orm] refactor(#1019)!: Restore the ORM date stamping through the metadata registry (#1090)

# Description

The ORM stamps a date on an entity again, and the entity holds no static
date
method.

Commit `d3cc39be2` deleted `Persister`, and the date stamping went with
it.
`Repository` replaced `Persister` from the query side, and `Repository`
never got
the two hooks that ran before a persist. #1019 records the
investigation: the
loss is accidental, because the commit kept the whole entity surface and
removed
each intentional target in full.

Two defects exist on `26.x` today:

- `Repository::delete()` runs a hard `DELETE` for every entity, and it
does not
test for `SoftDeleteEntityContract`. A caller that soft deletes a row
destroys
  the row.
- `Repository::create()` builds the `INSERT` from `asStorableArray()`,
which
  reads `get_object_vars($this)`. `DatedFields::$date_created` and
`$date_modified` are typed `string` with no default value, so PHP leaves
them
uninitialized and `get_object_vars()` omits them. A new `DatedEntity`
therefore
  returns `['id' => 1]`, and the `INSERT` carries no date column at all.

This pull request restores the stamping in `Repository`, and it moves
the date
metadata to the registry that valkyrjaio/valkyrja-php#1088 adds.

## Why the repository, and not a middleware or a listener

`Repository` is the only class that knows the persist verb. The date to
write
depends on whether the next statement is an `INSERT`, an `UPDATE` or a
`DELETE`.
`Persister` was the same seam under an older name.

A middleware does not fit, because the ORM has no persist middleware
pipeline.
`Orm\Middleware\EntityRouteMatchedMiddleware` is HTTP route middleware,
and it is
unrelated. A listener does not fit either, because a listener makes the
stamp
optional and dependent on the order of the listeners. A create that runs
without
a created date writes a bad row.

## Why one pull request, and not two

`AGENTS.md` §4 ("What a data object holds") forbid... (continued)

63 of 0 new or added lines in 0 files covered. (NaN%)

12914 of 12914 relevant lines covered (100.0%)

24.45 hits per line