bleedingdeacons / trusted / 30721975110
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 23
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.051%. Remained the same
30721975110

push

github

web-flow 
chore(tests): use the shared Unity test doubles (#29)

Unity now ships Unity\Testing\Doubles — MemberStub, InMemoryMemberRepository
and FakeContainer — for the suite to test against, so this plugin stops
maintaining its own. Net 251 lines removed, with no change to what is
covered: 166 tests, 388 assertions, still green.

  - ResponderStub: 143 lines to 45. It now extends MemberStub, which carries
    the 23 accessors of Unity's Member contract, and keeps only what is
    specific to this suite — a member is a telephone responder unless a test
    says otherwise, and the identity fields hold values rather than empty
    strings so assertions read as names. Those defaults belong here, not in
    Unity, whose stub stays neutral for the other plugins. Every call site is
    untouched; the named arguments still work.
  - tests/Fixtures/InMemoryMemberRepository.php: deleted, and its seven
    importers repointed at Unity's. The shared one filters
    findTelephoneResponders() the same way and reports writes successful,
    which is what this suite's copy did.
  - FakeUnityContainer: deleted from TrustedServiceProviderTest in favour of
    FakeContainer, which additionally caches like the real container and
    throws the real DependencyNotRegisteredException.

The bootstrap now registers a PSR-4 autoloader over ../unity/src — the
pattern Amber, Reconcile, Trumpet and Scrutiny already use — rather than
requiring three named files. That is what makes Unity\Testing\Doubles
reachable.

Its eval() fallback, which defined Member, MemberRepository and
ResponderCertification inline so the suite would run from a bare clone of
this repo alone, is gone. It was a hand-copy of a contract owned elsewhere,
kept in step by discipline; its own comment warned that "the stub must stay
in step with Unity's real interface ... which is exactly how Reach's suite
came to be broken". It never ran in CI, which always checks Unity out, so
nothing would have caught it going stale — a... (continued)

1098 of 1180 relevant lines covered (93.05%)

3.02 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30721975110.1 23
93.05
GitHub Action Run
Source Files on build 30721975110