valkyrjaio / project-template-java / 30721326014
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30721326014

push

github

web-flow 
[Version] test: Assert the info constants by format instead of exact values (#55)

# Description

The release workflow rewrites `VERSION` and `VERSION_BUILD_DATE_TIME` on
every release. The test asserted only that each constant is not empty,
which cannot catch a value written in the wrong format.

The TypeScript template showed what the weak assertion misses. Its test
compared the exact values `1.0.0` and `January 1 2025 00:00:00 MST`, so
the first release broke it and blocked every open pull request. This
change does not copy that mistake — it asserts a format, so a release
can never break the test, and a malformed value still fails it.

Each test now matches the exact format that the release workflow writes:

- `VERSION` matches `\d+\.\d+\.\d+`.
- `VERSION_BUILD_DATE_TIME` matches `[A-Z][a-z]+ \d{1,2} \d{4}
\d{2}:\d{2}:\d{2} MST`, the output of `date '+%B %-d %Y %T MST'` in
`_get-version-for-release.yml`.

## Types of changes

- [X] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement


## Changes

-
**`.github/ci/junit/src/test/java/io/valkyrja/tests/unit/template/constant/TemplateInfoTest.java`**
— replaced the two `assertNotEquals("", …)` assertions with
`String.matches` on the version format and the build-date-time format,
and renamed each test method for what it now asserts. Each assertion
carries a failure message that prints the offending value.

## Sibling pull requests

This change is made in every affected language port in the same batch.

- PHP — https://github.com/valkyrjaio/project-template-php/pull/176
- Go — https://github.com/valkyrjaio/project-template-go/pull/32
- Python — https://github.com/valkyrjaio/project-template-... (continued)

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30721326014.1 1
100.0
 GitHub Action Run
Source Files on build 30721326014