archetech / archon / 30716545736

89%

main: 94%

Pull #822

github

ci: count untested files with collectCoverageFrom

Without collectCoverageFrom, only files a test actually loads enter the
coverage denominator, so untested files are invisible rather than zero.
Two consequences drove this whole series: a refactor that adds tests for
previously-untested code makes coverage *drop* (#705, 91.63% -> 90.26%),
and a surface with no tests at all registers a 0.00 delta and can never
show a regression (#706 split keymaster-api.ts into 22 untested routers
and moved the number not at all).

Now that the service surfaces are covered — gatekeeper and keymaster
server at 100%, drawbridge 99%, herald 81% — the untested remainder is
small enough to count honestly.

Three traps found while writing this, each caught by diffing per-file
coverage before and after rather than by reading the config:

- collectCoverageFrom REPLACES the default rather than adding to it. A
  first draft listing only the four service directories "improved" the
  total to 74.05% because it had silently stopped measuring packages/*
  altogether. Every directory to be measured must be enumerated.
- `!**/index.ts` swallowed services/herald/server/src/oauth/index.ts, a
  real module with 178 covered lines. Narrowed to package barrels only.
- `!**/db/sqlite.ts` swallowed packages/keymaster/src/db/sqlite.ts, which
  is tested at 27/29. Narrowed to the specific herald path.

The exclusion line is now principled and verified per file: excluded
means structurally unable to run in the unit environment (herald's
db/sqlite.ts imports better-sqlite3, which is absent from root), while
visible-at-0% means testable but untested. Gatekeeper's db/sqlite.ts
imports sqlite3, which resolves fine, so it is counted rather than
hidden.

Reported total moves 95.42% -> 92.06%, which now includes 338 uncovered
lines that were previously invisible — chiefly gatekeeper's sqlite
backend (166) and the IPFS kubo client (116). Nothing that had coverage
was hidden; verified by comparing every ... (continued)

3344 of 4060 branches covered (82.36%)

Branch coverage included in aggregate %.

7832 of 8509 relevant lines covered (92.04%)

668.33 hits per line