archetech / archon / 30714431035

92%

main: 94%

Pull #821

github

test(herald): cover the deferred route handlers

Follow-up to #820, which landed the routes extraction with routes.ts at
45% and split the awkward handlers out rather than rushing them.

Adds 41 tests (42 -> 83), taking routes.ts to 80.8% and the repo total
from 92.91% to 95.42%.

- Inbound email webhook (the largest single gap): unconfigured bridge,
  missing fields, spam-score rejection, expired reply token, a reply
  delivered as a dmail referencing the original, unrecognized recipient,
  unknown herald name, and unsolicited delivery to a known name. Also the
  deliberate 200 {action:'error'} on failure — worth knowing, since it
  means the provider will not retry a genuinely broken delivery.
- Outbound send-email: bridge gate, bearer auth, the herald-name
  requirement, field validation, success, and failure.
- IPNS publication: the IPFS add -> IPNS publish sequence with fetch
  stubbed, asserting the actual URLs, both failure modes, and the
  owner-only gate.
- Session-based profile name: read, cross-user 403, invalid and taken
  names, assignment with credential issuance, deletion with revocation.
- Admin user deletion, including the guard refusing to delete the owner.
- Member lookup with name normalization; LNURLp payRequest, amount-range
  rejection, msat->sat conversion, both invoice field spellings, and
  endpoint failure.
- Login challenge and avatar serving, including the content-type
  allowlist falling back to octet-stream for image/svg+xml.

The dmail poll loop (~45 lines) is deliberately left uncovered.
startDmailPollLoop installs a setInterval, and an un-cleared interval is
the leaked-handle pattern that hangs Jest in CI, which runs without
--forceExit. Testing it needs fake timers plus a teardown hook, which is
worth doing deliberately rather than bolting on here.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

3596 of 4238 branches covered (84.85%)

Branch coverage included in aggregate %.

8277 of 8675 relevant lines covered (95.41%)

657.8 hits per line