lsm / HyperNeo / 30700606999

83%

push

github

fix: raise Fullstack QA Loop cyclic channel maxCycles 6 → 50 (#2275)

* fix: raise Fullstack QA Loop cyclic channel maxCycles 6 → 50

PR lsm/HyperNeo#2262 hit the previous maxCycles: 6 cap on round 7 of a
legitimate review loop — the Reviewer's in-band send_message to Coding was
rejected with "Cyclic channel ... has reached the maximum cycle count (6)".
7 rounds is legitimate for a non-trivial PR; a cap of 6 is too tight.

Raise maxCycles 6 → 50 on both Fullstack QA Loop cyclic back-channels:
  - Review → Coding (feedback)
  - QA → Coding (issues found)

Add a regression test pinning both channels to maxCycles: 50 (and a
behavioral guard > 6) so the cap cannot silently regress.

Scope decisions:
  - Runtime fallback default `?? 5` (channel-router.ts, space-runtime.ts)
    is intentionally untouched — it is a separate concern from the
    explicit `6` on this template.
  - Other built-in workflows' explicit maxCycles: 5 are left as-is.
  - Change applies to NEW workflow runs only. Existing in-flight runs
    seeded with maxCycles: 6 in the DB keep their old cap (the actionable
    feedback for the triggering run was already rerouted via the GitHub PR
    review, so no data was lost). No DB migration.

* fix: propagate template channel maxCycles/label onto existing spaces

Addresses review feedback on PR #2275: raising the template cap 6 → 50
alone does NOT reach existing spaces. mergeChannelsFromTemplate matched
channels by {from,to,gateId} and returned existing channels verbatim, so
the Fullstack back-channels kept maxCycles: 6. Meanwhile the re-stamp
wrote templateHash unconditionally but wrote `channels` only on
add/remove — so on the first restart the hash was bumped to the 50-hash
while the channels stayed at 6, and the matching hash then skipped the
row on every future startup. Net effect: the increase reached only
newly-created spaces; every existing space kept maxCycles:6 permanently
with no self-heal path.

Fix:
  - mergeChannelsFromTemplate n... (continued)

11688 of 16768 branches covered (69.7%)

Branch coverage included in aggregate %.

35 of 0 new or added lines in 0 files covered. (NaN%)

100182 of 118551 relevant lines covered (84.51%)

302.68 hits per line