twbs / bootstrap / 30682176112

94%

main: 96%

push

github

Fix custom mouse event handler semantics (#42778)

`EventHandler` emulates `mouseenter` and `mouseleave` with `mouseover` and `mouseout`
listeners. The guard that kept the emulation honest read `originalTypeEvent in
customEvents`, which only matches the bare strings. Every component namespaces its
events, so no component ever got the containment check. The guard also wrapped the
caller's callback and stored the wrapper, so removal by reference, deduplication and
one-off bookkeeping all compared against a function the caller never held.

Store the semantic event type on the handler instead, and apply the containment check
inside the handler. This keeps the caller's function identity intact and fixes Carousel
resuming autoplay between slides, Tooltip hiding between children of its trigger, and
Menu leaking a submenu listener on each close.

Co-authored-by: ShiroKSH <kushidashiro@gmail.com>

1745 of 1961 branches covered (88.99%)

Branch coverage included in aggregate %.

32 of 32 new or added lines in 1 file covered. (100.0%)

3594 of 3724 relevant lines covered (96.51%)

111.43 hits per line