dangernoodle-io / breadboard / 30680483108

97%

push

github

fix: unconditionally compile bb_system_boot_banner.c, gate body internally (#1178)

Another instance of the Kconfig-gated-SRCS defect class (companion to
B1-1336): bb_system's CMakeLists.txt had a second, separate
if(CONFIG_BB_SYSTEM_BOOT_BANNER) list(APPEND ...) gate around
bb_system_boot_banner.c's SRCS entry, while the header's
// bbtool:init tier=early fn=bb_system_boot_banner_init marker on
bb_system_boot_banner_init() is unconditional -- codegen is
Kconfig-blind by design (it runs before Kconfig resolution) and
always emits the call. Here the declaration in bb_system.h was
already unconditional (unlike B1-1336's bb_diag_http cases, whose
declarations were also #if-gated and so failed at compile time), so
CONFIG_BB_SYSTEM_BOOT_BANNER=n instead failed at LINK time with an
undefined reference to bb_system_boot_banner_init.

This instance was found by running a WIP lint (init-marker-gated-srcs,
B1-1337) from the unmerged local branch jae/lint-gated-srcs -- that
branch is NOT landed (not on main, not on this branch, no open PR), so
this class is NOT yet caught automatically by make check/CI; the
earlier manual sweep missed it because bb_system's CMakeLists.txt has
TWO separate if(CONFIG_...) SRCS gates and only the
BB_SYSTEM_ROUTES_AUTOREGISTER one (already fixed in B1-1332) was
examined -- the BB_SYSTEM_BOOT_BANNER gate was never opened. The
landing order is circular by necessity: B1-1337 cannot land before
this fix, because the lint fires on this very instance and would break
make check, make test-py, and make smoke-esp32. This fix lands first;
the lint lands immediately after.

Move the Kconfig check inside bb_system_boot_banner.c (mirroring
bb_log_http.c's #if defined(X) && X / #else no-op stub shape); the
SRCS entry is now unconditional. bb_system_boot_banner_format() lives
in a separate, always-compiled file and is unaffected.

Adds a compile-gate smoke variant (esp32-no-banner) proving both
directions: reverting the SRCS fix and building it re... (continued)

8101 of 8674 branches covered (93.39%)

Branch coverage included in aggregate %.

13740 of 13895 relevant lines covered (98.88%)

2572.06 hits per line