dangernoodle-io / breadboard / 30679398676

97%

push

github

fix: unconditionally declare bb_diag_routes_init/bb_diag_sections_init (B1-1336) (#1176)

bb_diag_http's CMakeLists.txt Kconfig-gated bb_diag_http_routes.c and
bb_diag_http_section_dispatch.c on CONFIG_BB_DIAG_ROUTES/
CONFIG_BB_DIAG_SECTIONS, while both functions' declarations in
include/bb_diag_http.h were ALSO #if-gated on those same symbols with no
#else stub. Both fns carry `// bbtool:init` markers in the consumer
manifest (examples/smoke/main/bb_wire.h), and codegen's marker scan is
grep-time with no preprocessor awareness -- it runs before Kconfig
resolution and emits an unconditional call regardless of the symbol's
value. Setting either symbol `n` therefore produced an
implicit-function-declaration compile error: codegen still called the fn,
but neither its declaration nor its definition existed in that build.

Fix belongs on the component side, not codegen: bb_diag_http already used
the correct pattern for its other two route surfaces --
CONFIG_BB_LOG_ROUTES (bb_log_http.c wraps its whole body in an in-file #if
with an #else no-op stub, unconditional declaration in bb_log_http.h) and
CONFIG_BB_STORAGE_HTTP_FACTORY_RESET (a static inline no-op stub in
bb_storage_http.h when off). This change makes CONFIG_BB_DIAG_ROUTES and
CONFIG_BB_DIAG_SECTIONS consistent with that same shape: both .c files now
always build (CMakeLists.txt), each gates its own body on its own Kconfig
symbol with an #else stub returning BB_OK, and both declarations in
bb_diag_http.h are now unconditional.

Adds an esp32-diag-headless smoke variant (CONFIG_BB_DIAG_ROUTES=n +
CONFIG_BB_DIAG_SECTIONS=n) proving this compiles clean, wired into the CI
smoke matrix. Verified the gate fires: reverting the header's declarations
back to #if-gated reproduces the exact implicit-declaration error against
this new env; restoring the fix builds clean, with the generated
config/sdkconfig.h confirming both symbols are genuinely absent. The new
env also sets CONFIG_LWIP_SO_LINGER=y (every env ... (continued)

8101 of 8674 branches covered (93.39%)

Branch coverage included in aggregate %.

13740 of 13895 relevant lines covered (98.88%)

2581.18 hits per line