valkyrjaio / valkyrja-starter-app-php / 30679102336
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 33
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30679102336

push

github

web-flow 
[Workflow] refactor: Split the pull request checks out of CI (#205)

# Description

Separates two concerns that shared one workflow, and one event
subscription.
Mirrors valkyrjaio/.github#209, which made the same change to the
templates.

`ci.yml` checked file content *and* pull request metadata. Those want
different
events, and a workflow subscribes only once, so the subscription was the
union of
both. `edited` was there for the metadata half, and the content half
paid for it:
editing a title on a code pull request re-ran the whole tool suite,
because a title
has nothing to do with `src/` and the workflow could not tell the
difference.

Neither obvious repair works, which is why this is a split and not a
condition:

- **Skipping the caller job** on an edit leaves the required status
check with no
`<job> / <job>` context to report, so the pull request blocks on
"Expected —
  Waiting for status to be reported" until someone pushes.
- **Guarding inside the job** is unsafe. The job reports success without
running the
tools, and that success lands on the same commit as the earlier real
result. Edit
  the description of a red pull request and it turns green.

So each workflow now subscribes to what it reads. `pr.yml` checks pull
request
metadata and takes `edited`. `ci.yml` checks file content and does not.
Each runs in
full whenever it runs, so nothing is guarded and nothing can be forged.

**The required status context does not change.** The context string is
the job-name
chain, not the workflow name: the job keeps the id
`commit-message-check` and the
name `Commit Message Check`, so `Commit Message Check / Check Commit
Message` still
reports, from `pr.yml` instead of `ci.yml`. No ruleset needs an edit.

**Both edits are in one commit on purpose.** Adding `pr.yml` first would
run the
commit check twice under one context name; removing the job from
`ci.yml` first
would leave the required check with nothing to report and block every
pull request
here. Toge... (continued)

517 of 517 relevant lines covered (100.0%)

2.12 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30679102336.1 33
100.0
 GitHub Action Run
Source Files on build 30679102336