dangernoodle-io / breadboard / 30678118823

97%

push

github

refactor: remove BB_SYSTEM_ROUTES_AUTOREGISTER Kconfig gate (#1174)

Composition knobs die per northstar: codegen and handwire are the only
sanctioned composition paths, and BB_SYSTEM_ROUTES_AUTOREGISTER was the
last of the six declared *_AUTOREGISTER symbols gating a component's
SRCS list.

The headless opt-out is not lost -- it moves to the composition layer.
A consumer that doesn't want POST /api/reboot simply omits
bb_system_routes_init from its manifest (or doesn't call it, if
hand-wiring) -- the same lever B1-1314's consumer manifests and
B1-1279 already rely on. bb_system_routes.c now always compiles and
its object is always archived into the component library on every
board; the linker does NOT strip it. Composition (not code presence)
is the lever -- omitting the manifest entry means bb_system_routes_init()
is never called, so no route is ever registered or reachable, but the
unreferenced object still carries a small, real flash cost.

The deleted Kconfig help text itself had drifted from reality: it
claimed the gate built routes for "/api/version, /api/reboot,
/api/ping" and added esp_timer to PRIV_REQUIRES. Neither is true --
the only route bb_system_routes.c has ever registered is POST
/api/reboot (bb_system_routes.h's own doc comment says so), and
esp_timer is not referenced anywhere in this component. Both stale
claims are evidence the knob's own documentation had drifted from
what the code actually does, on top of it being redundant with the
composition layer.

This dissolves one of B1-1334's three Kconfig-gated-SRCS instances (a
consumer naming bb_system_routes_init in its manifest while setting
=n got a link error, since codegen is Kconfig-blind) -- leaving
BB_DIAG_ROUTES/BB_DIAG_SECTIONS, tracked as B1-1336.

Downstream verified safe: TaipanMiner (all 7 board configs),
TaipanMiner-webui-ws, and taipan-brood all set =y, matching the
default, and all are pinned to older breadboard commits, so removal is
invisible until resync.

di_lega... (continued)

8101 of 8674 branches covered (93.39%)

Branch coverage included in aggregate %.

13740 of 13895 relevant lines covered (98.88%)

2572.33 hits per line