umputun / agterm / 30677818036

98%

push

github

feat(dashboard): accept <id>:left / :right pane refs in the ids argument (#334)

`agtermctl dashboard` took session ids, and a split session always contributed both panes as cells, so one pane of a split could not be put on the grid. Each positional id can now carry a `:left`/`:right` suffix naming one pane:

```
agtermctl dashboard A1B2C3D4                      # unchanged: every pane of the session
agtermctl dashboard A1B2C3D4:left                 # main pane only
agtermctl dashboard A1B2C3D4:left E5F6A7B8:right  # mixed, per id
```

a bare id is unchanged. The suffix is the same form `tree --json` already reports in `dashboardMembers`, so write and read round-trip, and it composes with any head (`active:left`, a unique prefix). It is case-insensitive.

this matters because the 9-cell cap counts panes and trims the tail. With nine sessions of which three are split, sessions 7-9 never reach the grid, so unwatched shell panes evict watched ones. There was no workaround: `session.split off` only hides the pane, `hasSplit` survives a hide, and only the pane's own shell exiting clears it.

**grammar**

split on the first colon, accept only `left`/`right`. Safe because a valid head can never contain a colon, since `ControlResolve.resolve` takes `active`, a full UUID, or a UUID prefix. So a pasted `surface:<id>:left` zoom address fails outright instead of half-resolving, and a typo like `A:lft` gets a real error instead of becoming a mystery `unresolved` entry.

malformed grammar is hard, a resolution miss is soft. `A:lft`, `A:primary`, `A:scratch` fail in the dispatcher; a well-formed `A:right` on a session with no split joins the `unresolved` note and the rest of the grid still opens. Cells dedup by session+pane, so `A A:left` collapses while `A:left A:right` stays two cells.

**two things pane refs exposed that bare ids never could**

the empty guard had to move from the resolved ids to the expanded members. A `:right` ref to an unsplit session resolves... (continued)

58 of 58 new or added lines in 5 files covered. (100.0%)

6635 of 6808 relevant lines covered (97.46%)

4416309.88 hits per line