dangernoodle-io / breadboard / 30673668678

97%

push

github

feat: hard-error server=true/registers_routes=true in component and platform headers (#1168)

Adds the B1-1320 ratchet closing epic B1-1314: codegen now hard-errors
(WireError, same shape as the existing component=/out= manifest-only
checks) if a server=true or registers_routes=true marker is found on a
component or platform header rather than a --consumer-manifest file.
Which HTTP routes a composition exposes is the consumer's decision --
wire.py's collect_entries globs every *.h in a composed component's
include dir and emits every marker found, so a component carrying its
own route marker was silently forcing that route onto every consumer
that merely composed it. The error names the offending file:line:fn
and points at the fix (move the marker to the consumer manifest, e.g.
examples/smoke/main/bb_wire.h, adding component=<name>).

Behavior-neutral today: origin/main carries zero surviving server=true/
registers_routes=true markers in any component or platform header (all
20 relocated by #1163-#1167), and regenerating codegen for both smoke
and floor after this change produces byte-identical output. The one
non-route server=true user found during this work, bb_http_server's
route-registry-cap audit (server=true only to get the handle + sort
position, body did (void)server), was NOT relocated -- #1167 removed it
outright, folding the check into registry_add() where it's order-
independent. So the gate carries no exception: every remaining
server=true/registers_routes=true user is a genuine route registration
now living in a manifest.

Proof the gate fires: adding a bogus server=true marker to a component
header (components/bb_health/include/bb_health.h) and to a platform
header (platform/espidf/bb_queue_espidf/bb_queue_espidf.h) each made
`bbtool codegen` hard-error with the expected file:line:fn message;
both were reverted and the tree confirmed clean before committing.

Also migrates the wire.py test suite's route-registering fixtures
(previously ... (continued)

8103 of 8676 branches covered (93.4%)

Branch coverage included in aggregate %.

13743 of 13898 relevant lines covered (98.88%)

2580.5 hits per line