bleedingdeacons / tsml-for-unity / 30669956802
94%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 55
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 94.252% (-0.04%) from 94.295%
30669956802

push

github

web-flow 
fix(logging): diagnostic traces are debug, not error (#40)

The change trackers logged routine events — a member captured before save,
a hook about to fire, a cache cleared — through Plugin::logError(), wrapped
in `defined('WP_DEBUG') && WP_DEBUG`. Both halves were wrong.

The level is simply incorrect: these are traces, not errors, and the trait
has exposed logDebug() all along. The practical cost is that
`wp log tail --level=error` on the test machine is mostly noise, so the one
command that should answer "did anything break?" cannot.

The guard is a second severity mechanism competing with the first. Sentinel
already filters on SENTINEL_LOG_LEVEL (default debug); gating on WP_DEBUG
decides severity again, somewhere else, in a way that is site-wide and cannot
be tuned per channel. Removed, so there is one control.

25 call sites across the four change trackers, plus the four now-dead
`use const WP_DEBUG` imports.

Note this is not log-volume-neutral: with SENTINEL_LOG_LEVEL at its default
of debug, a site running WP_DEBUG off goes from no entries to one per member,
group, position and intergroup-meeting save. Set SENTINEL_LOG_LEVEL to notice
on any install that does not want the trace.

tests/bootstrap.php no longer defines WP_DEBUG — it was defined purely to make
these branches run under test, and they run unconditionally now.

622 tests / 1743 assertions, unchanged. PHPStan clean. Line coverage
2693/2873 (93.73%) against 2718/2898 (93.79%): both numerator and denominator
fall by exactly 25, the guard lines themselves, every one of which was covered.

3099 of 3288 relevant lines covered (94.25%)

5.96 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
96.19
-0.24% tsml-for-unity/tsml-for-unity/src/Members/TsmlMemberChangeTracker.php
1
97.22
-0.19% tsml-for-unity/tsml-for-unity/src/Groups/TsmlGroupChangeTracker.php
Jobs
ID Job ID Ran Files Coverage
1 30669956802.1 55
94.25
GitHub Action Run
Source Files on build 30669956802