dangernoodle-io / breadboard / 30668594801

97%

push

github

refactor: relocate bb_mdns/bb_log_event route markers to manifest (#1166)

B1-1318 (epic B1-1314), fourth batch after #1163 (B1-1315), #1164
(B1-1316), #1165 (B1-1317). Independently enumerated the marker set across
BOTH components/**/*.h AND platform/**/*.h (never trusting the ticket's
per-component counts, which have been wrong once this epic already) --
exactly three `server=true` markers scoped to this batch, one per
component:

- bb_mdns_registry_init (components/bb_mdns/include/bb_mdns.h)
- bb_display_info_register_init (components/display/bb_display/include/
  bb_display_info.h -- nested one level deeper than the usual
  components/<name>/include/)
- bb_log_event_init (platform/espidf/bb_log_event/bb_log_event.h --
  platform-only, flat layout, no include/ subdir)

Two of the three relocate normally, mirroring batches 1-3's shape exactly:
bb_mdns_registry_init and bb_log_event_init move into
examples/smoke/main/bb_wire.h as manifest-only entries with
`component=<name>` (B1-1275) pulling each component's own REQUIRES/
PRIV_REQUIRES closure. bb_log_event_init is this epic's first relocated
marker living outside components/<name>/include/ -- confirmed it behaves
identically: wire.py's _component_headers falls back to a component's flat
directory (no include/ subdir) the same way for both components/ and
platform/ layouts, so a platform-only marker is globbed and relocated no
differently than a components/ one.

The third, bb_display_info_register_init, is DELIBERATELY ASYMMETRIC --
its header marker is deleted, but no manifest entry replaces it:

- Removing the marker changes nothing for any build today. Smoke's wire
  generation (`bbtool codegen --wire-board smoke_wire_baseline`, shared by
  all four smoke-gen-* Makefile targets) is deliberately board-invariant
  and its fixed baseline never included bb_display -- the function
  currently has zero generated call sites anywhere in this repo, on any
  board, before this change.
- It DOES close a re... (continued)

8092 of 8668 branches covered (93.35%)

Branch coverage included in aggregate %.

13719 of 13874 relevant lines covered (98.88%)

2580.64 hits per line