dangernoodle-io / breadboard / 30665664229

97%

push

github

refactor: relocate bb_diag_http/bb_wifi_http/bb_sensor_http route markers to manifest (#1164)

B1-1316 (epic B1-1314), second batch after #1163 (B1-1315). Moves every
`server=true` `// bbtool:init` marker off bb_diag_http/bb_wifi_http/
bb_sensor_http component headers into examples/smoke/main/bb_wire.h as
manifest-only entries, `component=<name>` pulling each component's own
REQUIRES/PRIV_REQUIRES closure (mirrors the bb_wifi_prov_autoinit precedent
and batch 1's shape exactly).

Moved (doc comments kept, only the marker line removed) -- five markers
across bb_diag_http's three headers (not four; the marker's own doc comment
calls out "diag-routes + sections" as two separate registry hooks):
- bb_storage_http_routes_init (components/bb_diag_http/include/bb_storage_http.h)
- bb_storage_http_factory_reset_routes_init (components/bb_diag_http/include/bb_storage_http.h)
- bb_log_register_routes_init (components/bb_diag_http/include/bb_log_http.h)
- bb_diag_routes_init (components/bb_diag_http/include/bb_diag_http.h)
- bb_diag_sections_init (components/bb_diag_http/include/bb_diag_http.h)
- bb_wifi_routes_init (components/bb_wifi_http/include/bb_wifi_http.h)
- bb_sensor_http_init (components/bb_sensor_http/include/bb_sensor_http.h)

Most pointedly bb_diag_routes_init/bb_diag_sections_init: GET
/api/diag/meminfo (a full heap layout, served unauthenticated on the
provisioning SoftAP -- B1-1279, hardware-confirmed) is registered through
these, so this batch is what makes it declinable at composition time.

Byte-identity does not hold (established in #1163, not chased here):
manifest entries always sort after every component-header entry
(`entries = collect_entries(...) + manifest_entries`, wire.py's `run()`,
tie-break `(order or +inf, global_parse_index)`). Gate instead:

1. `http_wildcard_last` guard passes non-vacuously -- `make smoke-gen-esp32`
   exits 0 with all seven relocated entries still ordered before
   bb_wifi_prov_autoinit's captive-portal marker... (continued)

8092 of 8668 branches covered (93.35%)

Branch coverage included in aggregate %.

13719 of 13874 relevant lines covered (98.88%)

2575.14 hits per line