decentraland / archipelago-workers / 30663802350

93%

main: 79%

Pull #128

github

test: cover the ws-connector changes and drop dead code

Coverage over the code the previous commit touched, plus the dead code that
review turned up.

The main find is that service.spec.ts was a third fake test, alongside the two
already replaced: it never imported main() and re-implemented the island_changed
forwarding inside the spec, so src/service.ts sat at 52% and would have passed
with the real handler broken. It now drives the real main() against a local NATS
broker, and moved to test/integration — it stands up a broker and exercises the
whole subscribe/decode/forward path, which is not a unit test.

New specs for ban-checker (the fetch injection is what made it testable),
peers-registry, getErrorMessage and the guarded NATS wrapper, plus the
protocol-violation branches of ws-handler and the error paths of ban-sweep.

Coverage of the changed files:

  ban-checker      52.38% -> 100%
  service.ts       52.38% -> 100%
  logic/nats.ts    33.33% -> 100%
  logic/errors.ts     75% -> 100%
  peers-registry      70% -> 100%
  ban-sweep         91.3% -> 100%
  ws-handler       81.67% -> 100% statements, 96.96% branches

Workspace total 77.72% -> 92.72% statements, 63.52% -> 81.92% branches.

Dead code:

- Remove the Parcel type and the WsApp type, both with zero references. WsApp
  was carried through the folder move without being checked.
- safeEndWebSocket had an unreachable branch: no call site passes a code without
  a message. Rather than delete it and leave a trap where a later caller passes
  one and has it silently dropped, the parameters now travel as a pair so the
  invalid combination cannot be expressed.
- Apply getErrorMessage to the three idioms missed in ws-handler last time
  ((err as Error).message and two catch (err: any)).

Not removed: google-protobuf and @types/google-protobuf are declared in both
workspaces and referenced in no TypeScript anywhere — the generated protocol
code uses protobufjs/minimal. Left for a deliberate decisio... (continued)

97 of 122 branches covered (79.51%)

Branch coverage included in aggregate %.

151 of 154 new or added lines in 20 files covered. (98.05%)

551 of 580 relevant lines covered (95.0%)

8.19 hits per line