decentraland / archipelago-workers / 30662368603

93%

main: 79%

Build Type

Pull #128

github

Committed by LautaroPetaccio

Commit Message

refactor: align ws-connector with WKC component standards

Counterpart to the same pass on comms-gatekeeper, on the code that becomes
the sole consumer of engine.peer.*.island_changed once core is removed.

- Extract the deny list out of the WebSocket handler into
  src/adapters/deny-list. It was a full adapter inlined into a 301-line
  controller: hardcoded URL, hand-rolled TTL cache, global fetch. The URL is
  now DENYLIST_JSON_URL, and the 5 minute TTL plus the deliberate
  advance-the-timestamp-even-on-failure behaviour are preserved.
- Inject the fetch component into ban-checker and deny-list instead of
  reaching for global fetch. It was already wired in BaseComponents and
  simply not passed.
- Take dependencies as Pick<AppComponents, ...> rather than inline
  structural types, matching stats/src/logic/subscriptions.ts.
- Move ban-checker, ban-sweep, peers-registry and deny-list to the
  component/types/index folder layout, with interfaces out of the
  implementation files. banSweep is now a named IBanSweepComponent.
- Upgrade @well-known-components/interfaces to ^1.5.2 in both workspaces and
  move ban-sweep to [START_COMPONENT]/[STOP_COMPONENT]. 1.4.3 neither
  exported the symbols nor deprecated the plain form. ban-sweep was the only
  component with a lifecycle to convert. The nats and server warnings that
  remain come from upstream packages.
- Add getErrorMessage, replacing four competing idioms and the catch (e: any)
  that went with them.
- Reuse the guarded() NATS callback wrapper from the stats service: a throw
  escaping one of these callbacks stops delivery on every subject, and
  comms-gatekeeper is the only publisher after this branch lands.
- JSDoc on the adapter factories and interfaces.

Tests:

- ws-handler.spec.ts tested no production code. It imported only Stage and
  WsUserData, never registerWsHandler, and every block re-implemented the
  logic it claimed to verify ("Replicates the FIXED fetchDenyList logic",
  "Replicates... (continued)

Pull Request Pull Request #128: feat: remove archipelago-core (clustering moves to Pulse)

Coverage Stats

83 of 124 branches covered (66.94%)

Branch coverage included in aggregate %.

116 of 144 new or added lines in 19 files covered. (80.56%)

27 existing lines in 2 files now uncovered.

493 of 578 relevant lines covered (85.29%)

5.74 hits per line