GrottoCenter / grottocenter-api / 30660514148

87%

develop: 91%

Build Type

Pull #1750

github

Committed by ClemRz

Commit Message

fix(document): replace m2m collections via replaceCollection on update and validate

- Use replaceCollection for authors, authorsGrotto, subjects, languages,
  massifs, isoRegions and countries in multiple-validate and
  update-with-new-entities instead of passing them to .set(), which
  Waterline silently ignores
- Wrap update-with-new-entities scalar update and replaceCollection calls
  in a single transaction to prevent partial writes
- Add parseIdList helper in DocumentService.getConvertedDataFromClient to
  distinguish undefined (untouched), '[]' sentinel (explicit clear) and
  array (replace) for multipart/form-data collection fields
- Fix getDocumentLanguages to return undefined instead of [] when neither
  language field is present, preventing silent language collection wipe
- Extract DOCUMENT_M2M_COLLECTIONS constant to config/constants/document.js
  as single source of truth for both controllers
- Add integration tests for collection replace, clear and untouched semantics
  with proper after() cleanup in multiple-validate and update-with-new-entities
- Document the '[]' sentinel protocol and the new-entities endpoint in
  swaggerV1.yaml

Pull Request Pull Request #1750: fix(document): replace m2m collections via replaceCollection on update and validate

Coverage Stats

5150 of 6194 branches covered (83.14%)

Branch coverage included in aggregate %.

46 of 47 new or added lines in 4 files covered. (97.87%)

15 existing lines in 2 files now uncovered.

9519 of 10609 relevant lines covered (89.73%)

133.94 hits per line