SAP / sqlalchemy-hana / 30645514530

96%

main: 95%

Build Type

push

github

Committed by web-flow

Commit Message

fix: render NOT (...) for negated boolean predicate on SAP HANA (#687)

Fixed negation of a grouped boolean predicate (e.g. ``~or_(...)``,
``~and_(...)`` or ``not_()`` of a grouping) compiling to ``(<predicate>)
= FALSE`` (or ``(<predicate>) = 0`` with ``use_native_boolean=False``),
which SAP HANA rejects with error ``257 ("incorrect syntax near '='")``.
Such implicitly-boolean expressions now render as ``NOT (...)``. Bare
boolean literals and boolean columns keep the explicit ``= TRUE``/``=
FALSE`` (``= 1``/``= 0``) comparison that SAP HANA requires.

Coverage Stats

27 of 28 new or added lines in 2 files covered. (96.43%)

21 existing lines in 1 file now uncovered.

1882 of 1963 relevant lines covered (95.87%)

0.96 hits per line