charmbracelet / ssh / 30652929025

62%

Build Type

push

github

Committed by taciturnaxolotl

Commit Message

fix: contain panics in port and agent forwarding too

Port forwarding and agent forwarding proxy data on their own goroutines,
which the previous change did not reach. These features are opt-in, so
most servers are unaffected, but a panic while proxying a forwarded
connection would still take the whole process down.

The agent proxy needed a little more care: its copy goroutines signalled
completion after copying rather than on the way out, so recovering a
panic there would have left the parent waiting forever, leaking the
goroutine along with the socket and the channel.

Coverage Stats

2 of 16 new or added lines in 2 files covered. (12.5%)

100 existing lines in 2 files now uncovered.

829 of 1330 relevant lines covered (62.33%)

539.61 hits per line