medplum / medplum / 30652284445

92%

push

github

Create `@medplum/storybook` package (#9956)

* Add `@medplum/storybook` package

We're looking to split some heavy-weight scheduling components into a
separate package from `@medplum/react` (we want to bundle some
heavy-weight dependencies without affecting existing users).

When we do that, we will want to be able to show stories from the new
package in the same Storybook instance. This can also help us move some
things like `react/src/stories/healthgorilla.ts` to somewhere like
`packages/health-gorilla-react/src/stories/` or do other similar
co-location into more appropriate packages.

To that end, we start by extracting a new `@medplum/storybook` package
which can import stories from other packages. Turborepo even suggests
a pattern for this: using relative paths in `.storybook/main` to bring
in files from elsewhere in the monorepo[^1].

We add a step in `scripts/cicd-deploy` to build the storybook and push
the result to an S3 bucket when there are changes in the
`packages/storybook` or `packages/react` directories (more to come
later). While we test this deployment path, that bucket is set up to
serve at storybook2.medplum.com, leaving the existing vercel deployment
in place.

[^1]: https://turborepo.dev/docs/guides/tools/storybook for details.

Signed-off-by: Noah Silas <noah@medplum.com>

* Exclude storybook from common `build` steps

To keep `npm run build` fast, we exclude storybook from it. Its build
step is more like the `docs` build step, preparing a bundle of assets
for release rather than preparing a package for consumption as a
dependency.

Signed-off-by: Noah Silas <noah@medplum.com>

* Exclude `storybook-static` built files from the linter

Previously, when running `npm run lint`, it would have started by
running `npm run build` inside `packages/react`, which as a side effect
runs `npm run clean`, which deletes the storybook-static directory.

In this new iteration, the storybook `build` step prepares those files,
and the linter will n... (continued)

22888 of 25980 branches covered (88.1%)

Branch coverage included in aggregate %.

40618 of 43013 relevant lines covered (94.43%)

12219.29 hits per line