medplum / medplum / 30650576940

92%

push

github

Use project branding in MFA emails and authenticator app entries (#10017)

* feat(server): brand MFA emails and authenticator entries per project

MFA content generated by the server hardcoded "Medplum", so a white-labeled
project's users received "Your Medplum verification code" emails and added
`medplum.com` entries to their authenticator apps.

A project can now set a `brandName` `Project.setting` entry, which names the
project in emailed MFA codes and in the issuer and account label of enrollment
QR codes. Projects without the setting keep the existing Medplum labels.

MFA code emails now also pass the project to `sendEmail`, so they go through
project SMTP like other project-scoped emails.

Signed-off-by: Derrick Farris <derrick@medplum.com>

* fix(server): put the brand in the TOTP issuer, not the account label

Building the account label as "<brand> - <email>" repeated the brand in
authenticator apps, which show the issuer as the entry title and the account
name beneath it: "Acme Health" / "Acme Health - alice@acme.com". Use the email
alone as the account name so an entry reads like any other service the user has
enrolled: "Acme Health" / "alice@acme.com".

Also handle two inputs that produced a broken entry:

- A colon in the brand name is now removed. The Key URI spec reserves it as the
  issuer/account separator, so "Acme: Health" was parsed by apps as the issuer
  "Acme" with the rest spilling into the account name.
- Users invited without an email address are identified by id rather than
  rendering the literal string "undefined" as the account name.

Signed-off-by: Derrick Farris <derrick@medplum.com>

* refactor(server): name the setting appName and brand the email sender

Align with the existing vocabulary for the user-facing product name:
MEDPLUM_APP_NAME / getAppName() in the app, so the project setting is appName
rather than a second "brand" noun. The reader moves to src/branding.ts, which
both auth and email can import without a cyc... (continued)

22888 of 25980 branches covered (88.1%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 4 files covered. (100.0%)

40618 of 43013 relevant lines covered (94.43%)

12219.29 hits per line