TillJan / dataverse / #16
25%
develop: 25%

LAST BUILD BRANCH: #12362-factory-method-for-JSONbuilders
DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1016
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 24.972% (-0.004%) from 24.976%
#16

push

github

poikilotherm 
build: remove dataverse-sca-config module and reorganize forbidden-apis plugin usage

While using the source code analysis config files from a Config JAR is a great idea in general, it will not work in our codebase.

As we do not use a parent POM at the root of our project, we cannot make the Maven Reactor pull in the dataverse-sca-config module during a build.

We'd need every developer to switch to using `mvn -f modules/dataverse-parent` all the time, which seems unlikely. Bad design choices in the past, not easy to resolve.

While we could push a built version to Maven Central, that would not help when modifying the signature file.

At the same time, using there is no reliable way to have an absolute path injected into a Maven property. We were using project.basedir within the parent POM before. This will be resolved at build time and always points to the directory where the current POM is running from. The reusability of this centralized plugin definition is rather limited, as it would fail to lookup the file in a different module.

The only way out of this:
1. Move the plugin into the dataverse module build chain.
2. This way, the resolved path is always correct, as it is model-bound, not half-parent-bound.
3. To still satisfy the request to avoid clutter in the project root, create a src/maven folder, ready to collect all these configurations.

23831 of 95429 relevant lines covered (24.97%)

0.25 hits per line

Coverage Regressions

Lines Coverage ∆ File
14
75.86
 -6.49% src/main/java/edu/harvard/iq/dataverse/util/json/JsonUtil.java
4
47.7
 -2.3% src/main/java/edu/harvard/iq/dataverse/dataaccess/DataAccess.java
Jobs
ID Job ID Ran Files Coverage
1 #16.1 1016
24.97
Source Files on build #16