opendefensecloud / solution-arsenal / 30627009835

82%

Build Type

push

github

Committed by web-flow

Commit Message

ci: tighten golangci-lint config and fix the findings it surfaces (#726)

## What
Tightens the golangci-lint config in three small ways and cleans up the
findings that surfaced from it

## Why
Three things were off in the config. 

* `nilnil` was listed in both `disable` and `enable`, and since
`default: none` the `disable` block did nothing anyway, so it was just
confusing noise and is gone now.
* `importas` was enabled but had no alias rules, so it did nothing and
golangci even warned about it on every run. It now enforces the aliases
we already use by convention (`metav1`, `corev1`, `solarv1alpha1`, and
the usual `k8s.io/api` group), so imports stay consistent instead of
drifting into `v1`, `k8smeta`, `authzv1` and friends.
* And our `test/e2e` files are build-tagged `e2e`, so golangci was
skipping them entirely, which is how a few things slipped past in the
past. `run.build-tags` now includes `e2e` so that code gets linted too.

Turning those on surfaced a bit of existing debt, which this PR cleans
up in the same go. A handful of import aliases got renamed to match the
new rules, and the e2e helpers got a few small fixes (blank lines before
returns, checked errors, import ordering). The e2e helpers legitimately
shell out to kubectl and print progress, and some helper params are
fixed by design, so `noctx`, `forbidigo` and `unparam` are excluded for
`test/e2e` only, since those checks are about production code paths, not
test scaffolding.

## Testing
`golangci-lint run ./...` is clean (0 issues), `go build ./...` and `go
vet ./...` pass, both including the e2e tag.

## Checklist
- [x] Tests added/updated (n/a, tooling + import aliases only)
- [x] No breaking changes (or upgrade path documented above)
- [x] Readable commit history (squashed and cleaned up as desired)
- [ ] AI code review considered and comments resolved


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Improved ... (continued)

Coverage Stats

11 of 11 new or added lines in 3 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

5251 of 6404 relevant lines covered (82.0%)

34.27 hits per line