kubernetes-sigs / kubebuilder / 30613200300

84%

master: 84%

Pull #5932

github

fix(go/v4): resolve create webhook target when several share a GVK

create webhook matched a recorded resource by Group, Version and Kind and
took the first hit. When a project records more than one external resource
that shares a GVK under different domains, it silently bound the webhook to
whichever entry the PROJECT file listed first, and passing --external-api-domain
to select another one failed outright.

Collect every Group/Version/Kind match instead of taking the first. With a
single match, behave as before. With several, use --external-api-domain to
select one, and return an error when it is missing or matches none so the
command never guesses and leaves the PROJECT file unchanged.

35 of 35 new or added lines in 1 file covered. (100.0%)

8247 of 9766 relevant lines covered (84.45%)

157.52 hits per line