AfterShip / clickhouse-sql-parser / 30619004754

55%

master: 55%

Build Type

Pull #295

github

Committed by Claudy

Commit Message

Merge join locality parsing into parseJoinModifiers

parseJoinLocality and parseJoinOp split one concept, the modifier
list that precedes JOIN, across two entry points, and every caller
had to pick the right one. parseJoinModifiers now owns the optional
GLOBAL/LOCAL locality and delegates the join-type matrix to
parseJoinType (renamed from parseJoinOp), so parseJoinRightExpr and
peekJoinAfterLocality each call a single function.

parseJoinRightExpr's locality and default branches collapse into
one, and peekJoinAfterLocality no longer re-implements the consume
locality, parse type, expect JOIN sequence; it defers to
parseJoinModifiers and treats a locality error such as GLOBAL ARRAY
JOIN as a join so the FROM clause reports the clearer message. Two
invalid-syntax tests pin dangling localities followed by another
clause (WHERE, SETTINGS). No behavior changes otherwise.

Assistant By Claude Fable 5

Pull Request Pull Request #295: Merge join locality parsing into parseJoinModifiers

Coverage Stats

18 of 22 new or added lines in 1 file covered. (81.82%)

166 existing lines in 1 file now uncovered.

9128 of 16627 relevant lines covered (54.9%)

3182.15 hits per line