stephendade / Rpanion-server / 30604350413

40%

Build Type

push

github

Committed by stephendade

Commit Message

index.js: add generic camera_command_ack handler, fix ack command IDs

Add a generic camera_command_ack listener so onMavPacket() can ACK any
MAVLink camera command (not just DO_DIGICAM_CONTROL) through one
event, including sendUnsupportedAck()'s MAV_RESULT_UNSUPPORTED acks
for commands/requests we don't implement.

Fix a bug in that handler: it accepted a result parameter but always
passed 0 (ACCEPTED) to sendCommandAck() regardless, which would have
silently turned every "unsupported" ACK into an "accepted" one.

Also fix the three existing camerainfo/videostreaminfo/camerasettings
handlers: they were acking the *requested message's* MSG_ID (e.g. 259
for CameraInformation) instead of the command that was actually sent
by the GCS, MAV_CMD_REQUEST_MESSAGE (512). A GCS matching acks to the
command it issued would never have seen these as acknowledged. Use
common.MavCmd['REQUEST_MESSAGE'] instead of the raw 512 literal.

Co-authored-by: Randy Mackay <rmackay9@yahoo.com>

Coverage Stats

380 of 1485 branches covered (25.59%)

Branch coverage included in aggregate %.

1 of 10 new or added lines in 1 file covered. (10.0%)

595 existing lines in 3 files now uncovered.

1206 of 3068 relevant lines covered (39.31%)

3.44 hits per line