dangernoodle-io / breadboard / 30599692258

97%

push

github

feat: activate the provisioning route gate (B1-1279 PR-4) (#1159)

Wires bb_wifi_prov_is_active() as bb_http_prov_gate's active-fn and
allowlists exactly the routes provisioning genuinely cannot complete
without -- closing the exposure PR-3 (#1156) left inert.

New pure, host-testable seam (wifi_prov_gate_wire.h/.c) registers:
  GET  /ping             project-wide liveness convention; bb_wifi_prov
                          never registers this route itself, but policy
                          requires it stay reachable regardless
  POST /save              the provisioning form's submit target
  POST /api/wifi/scan     the SSID-list fetch the default portal page's
                          own script issues on load
  GET  <assets[i].path>  one entry per caller-supplied asset -- the
                          portal page itself plus any additional assets
                          a custom-branded portal serves

Deliberately does NOT allowlist bb_wifi_prov_start()'s optional extra()
consumer routes (advanced-UI backing routes) -- the base flow above does
not need them, and the gate's whole purpose is to keep anything not
proven necessary unreachable while provisioning is active.

bb_wifi_prov_start() calls this once (guarded by s_gate_wired) before
returning, always before wp_active_on_entry can flip the gate active, so
the gate is never active with an incomplete allowlist.

Host tests exercise the SAME production allowlist through the real
bb_http_host_* dispatch mirrors: /api/diag/meminfo (the route confirmed
leaking on hardware), /api/reboot, and a non-/api route all 404 with
their handler unreached while active, and are unaffected when inactive.
Non-vacuity confirmed by neutering wifi_prov_gate_wire_register() to a
no-op: exactly the 8 tests exercising its allowlist content failed;
restored and re-verified green.

Review fix (MEDIUM): an allowlist-registration failure (composition's
fixed(3)+n entries exceeding BB_HTTP_PROV_ALLOWLIST_CAP) was only lo... (continued)

8080 of 8656 branches covered (93.35%)

Branch coverage included in aggregate %.

19 of 19 new or added lines in 1 file covered. (100.0%)

13676 of 13831 relevant lines covered (98.88%)

2606.39 hits per line