lsm / HyperNeo / 30599010476

83%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: remove Validation Complete node from Coding workflow (#2269)

* refactor: remove Validation Complete node from Coding workflow

The Coding workflow had a third 'Validation Complete' node as an escape
hatch for validation-only tasks (no code changes, no PR). It added a whole
node + agent slot + prompt + back-channel for a case that belongs in the
Review-Only workflow, not here.

- Remove the Validation Complete node, its two channels, the
  validation-complete-gate, and the VALIDATION_NO_CHANGES bash script
  from CODING_WORKFLOW. The graph is now a pure two-node Coding <-> Review
  loop; pr_ready on Coding->Review is unchanged.
- Update the coder prompt: validation-only / no-change tasks now flag the
  misroute to the task-agent instead of handing off to a removed node.
- Drop the now-dead validation-complete-gate migration patterns
  (KNOWN_GATE_PATTERNS, isBuiltInGateShape case, VALIDATION_ONLY_SCRIPT,
  ALLOW_SCRIPT) from workflow-migration.ts.
- Add a restamp migration (stripRetiredValidationComplete) so existing
  spaces seeded with the 3-node template shed the retired node, channels,
  generated hooks, and gate on the next daemon start. Add a retired
  coder-prompt variant so persisted step-7 text is patched too.
- Update tests across built-in-workflows, workflow-migration-replay,
  post-approval-router, space-runtime-completion, and
  space-workflow-handlers for the two-node shape, and add a migration test
  proving the restamp strips the old 3-node structure.

* address review: fix coder escalation target + guard migration precision

- Coder step 7: escalate a no-change/misrouted task to `space-agent` (the
  supported send_message target) instead of `task-agent`, which
  translateLegacyNodeTarget rejects. Don't claim reassignment; just surface
  the misroute and wait. (Codex P1 #1/#2)
- stripRetiredValidationComplete: only fire when the row still carries a
  built-in validation marker (validation-complete-gate or one of the
  generat... (continued)

Coverage Stats

11633 of 16733 branches covered (69.52%)

Branch coverage included in aggregate %.

70 of 0 new or added lines in 0 files covered. (NaN%)

2 existing lines in 1 file now uncovered.

99701 of 117947 relevant lines covered (84.53%)

303.49 hits per line