dangernoodle-io / breadboard / 30592839699

97%

push

github

refactor: compose smoke's /ping, /ws, /api/wsbcast routes via codegen (#1155)

examples/smoke is strictly codegen-composed (CLAUDE.md) -- these three
route registrations were hand-wired in smoke_app_setup() only because
their handlers were `static`, invisible to the generated composition
root's separate translation unit. This is a C linkage property, not a
codegen limitation -- a `static` handler has no symbol the generated
TU can reference, and no grammar addition could close that. Drop
`static`, declare the handlers in a new
examples/smoke/include/smoke_routes.h, and move registration into
examples/smoke/main/bb_wire.h as `args=`-parameterized manifest
markers (bb_app_http_handle threaded explicitly, matching the existing
bb_wifi_prov_autoinit marker's convention).

The three markers carry `registers_routes=true` (landed in #1153) so
the `provides=http_wildcard_last` ordering guard genuinely covers them
-- not just textual placement winning a parse-order tie-break, which
is the B1-1278 failure mode. Verified: temporarily reordering /ping
after bb_wifi_prov's captive-portal marker made `codegen` hard-error
("registers_routes=true entry sorts at or after ... which provides
'http_wildcard_last'"); restoring the correct order passed cleanly.

Behaviour narrowing (user-approved): /ping was previously registered
for every backend including Arduino, but entry_arduino.cpp never calls
bb_app_init*() and codegen only runs for ESP-IDF, so /ping no longer
exists on the r4_wifis3 and uno_cc3000 smoke envs. /ws and
/api/wsbcast were already ESP-IDF-only.


Claude-Session: https://claude.ai/code/session_0119nuE2NZME9y2aYEVJTPB5

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

7979 of 8582 branches covered (92.97%)

Branch coverage included in aggregate %.

13568 of 13723 relevant lines covered (98.87%)

2600.52 hits per line