dangernoodle-io / breadboard / 30591377870

97%

push

github

feat: close args= blind spot in http_wildcard_last ordering guard (#1153)

PR #1144's provides=http_wildcard_last codegen guard hard-errors when a
server=true entry sorts at or after the marked wildcard-catching entry
(bb_wifi_prov's captive GET /*), closing the B1-1278 regression where
/ping failed to register on provisioning boots. The guard's own docstring
documented a known blind spot: server=true is its only signal, and
args=/server=true are mutually exclusive at parse time, so an
args=-shaped entry that registers HTTP routes internally is structurally
invisible to it. This was "not live today" per that docstring -- until
now: jae/smoke-compose-routes composes three args=-shaped route
registrations (GET /ping, /ws, POST /api/wsbcast) that currently stay
ordered only by textual-placement tie-break; a future no-order= entry
would silently re-break /ping exactly as B1-1278 did.

Closes the gap with a dedicated opt-in key, registers_routes=true,
rather than relaxing the args=/server= mutual exclusion (server=true
also means "inject the http handle as first argument", which would
conflict with an explicit args= list) or inferring route-registration
from args= referencing bb_app_http_handle (fragile -- would silently
miss a route registered via a different handle expression). An entry
carrying registers_routes=true is checked by the exact same
sort-position-in-the-final-ordered-list logic as server=true entries,
so tier-major ordering and same-tier requires=/provides=/tie-break
resolution stay authoritative. The wildcard entry itself is excluded by
identity (`e is wildcard_entry`), not by the absence of the new key, so
it can never flag itself. Mutually exclusive with server=true at parse
time (redundant otherwise). Codegen-time gate only -- adds no emitted
text; verified byte-identical generated output for examples/floor and
examples/smoke against a detached origin/main worktree.

7979 of 8582 branches covered (92.97%)

Branch coverage included in aggregate %.

13568 of 13723 relevant lines covered (98.87%)

2607.42 hits per line