dangernoodle-io / breadboard / 30587396835

97%

push

github

feat: enable FreeRTOS trace facility in smoke builds for per-task stack watermarks (#1151)

CONFIG_FREERTOS_USE_TRACE_FACILITY was unset across the smoke fleet, so
bb_task_registry_base_scan_start() compiled to a no-op and GET
/api/diag/tasks could never report real per-task stack high-water marks.
That measurement was exactly what was missing while diagnosing B1-1284, a
hardware-confirmed httpd task stack overflow -- only a throwaway diagnostic
build with the flag on made /api/diag/tasks non-stub and gave real
watermarks.

Enable CONFIG_FREERTOS_USE_TRACE_FACILITY=y on the five CI-matrix smoke
envs (esp32, esp32c3, tdongle, elecrow-p4-hmi7, esp32-cache-sweep); each
sdkconfig.defaults.* is standalone (not layered), so each needs its own
line. Only the symbol uxTaskGetSystemState() actually requires
(CONFIG_FREERTOS_USE_TRACE_FACILITY) is enabled -- VTASKLIST_INCLUDE_COREID
and GENERATE_RUN_TIME_STATS stay off (they only gate the optional
core/runtime fields in the diag response, and the latter is the much
heavier, unrelated runtime-stats feature this task explicitly excludes).
esp32-autofan/esp32-boot-status/esp32-boot-progress are left untouched:
they already fail to build for the unrelated pre-existing reason B1-1145,
so the flag can't be verified there and is deferred to whoever fixes that
build.

examples/floor already has CONFIG_FREERTOS_USE_TRACE_FACILITY=y -- landed
in PR #1131 (aff12c90) as a `chore:` -- so there was nothing to do there;
this PR only closes the gap on the five smoke envs. Kept `feat:` here
rather than matching #1131's `chore:` because the outcome is API-visible
on shipping smoke boards: a previously-permanent-stub GET /api/diag/tasks
becomes functionally non-stub across the whole smoke matrix, not just a
single bench-measurement board explicitly documented as "not a shipping
default" (floor's comment).

This flag's RAM cost is structural, not a flat one-time charge: with
configUSE_TRACE_FACILITY on, FreeRTOS adds uxTCBNumber/u... (continued)

7973 of 8576 branches covered (92.97%)

Branch coverage included in aggregate %.

13540 of 13695 relevant lines covered (98.87%)

2603.13 hits per line