jhillyerd / enmime / 30562203401

87%

push

github

mediatype: dedup params by exact name, not substring (#406)

fixMangledMediaType dropped a distinct parameter whenever its "<name>="
token was a substring of the accumulated parameter string -- most often
when the name is a suffix of an earlier one (name after filename, id
after uuid, type after subtype) or appears inside an earlier value. This
silently discarded valid parameters that Go's mime.ParseMediaType keeps;
e.g. `filename="a"; name="b"` lost `name`, dropping attachment filenames.

Track seen parameter names in an exact, case-insensitive set (RFC 2045
section 5.1) so only true duplicate keys are removed, preserving the #162
behavior of collapsing exact repeats.

4 of 4 new or added lines in 1 file covered. (100.0%)

3280 of 3796 relevant lines covered (86.41%)

4325.22 hits per line