GEWIS / sudosos-backend / 30546636270

92%

push

github

fix: notify users of the amount actually deducted for inactive administrative costs (#996)

sendInactiveNotification always told users the full configured
administrativeCostValue would be deducted, even when their balance was
lower than that. The handout flow already caps the deduction to
min(balance, administrativeCostValue) and never goes negative, so a user
with a lower balance was told an amount that could never actually be
deducted (e.g. "EUR 10.00" when they only had EUR 3.00).

Extract that capping logic into a shared getDeductionAmount helper used
by both createInactiveAdministrativeCost (handout) and
sendInactiveNotification (warning), so the two mails agree on the amount.

Also fixes the template appending a redundant "euro"/"euros" after an
already-formatted currency string, e.g. "EUR 10.00 euro".

Fixes GEWIS/sudosos-backend#972

4424 of 5034 branches covered (87.88%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 3 files covered. (100.0%)

22544 of 24194 relevant lines covered (93.18%)

826.5 hits per line