xemul / criu / 557
64%
master: 66%

LAST BUILD BRANCH: criu-dev
DEFAULT BRANCH: master
Ran
Jobs 6
Files 121
Run time 11min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
557

push

travis-ci

xemul 
nmk/script: rm bad code

I discovered that the scripts/ suffix is added to __nmk_dir despite
the fact it already contains it, ending in obviously wrong filenames
like scripts/nmk/scripts/scripts/msg.mk. As those files are non-existent,
make tried to recreate every .mk file, spawninga child to execute 'true'
command, like this (part of "make -dr" output):

> Considering target file '../scripts/nmk/scripts/scripts/include.mk'.
>  File '../scripts/nmk/scripts/scripts/include.mk' does not exist.
>  Finished prerequisites of target file
> '../scripts/nmk/scripts/scripts/include.mk'.
> Must remake target '../scripts/nmk/scripts/scripts/include.mk'.
> Putting child 0x564ec1768740 (../scripts/nmk/scripts/scripts/include.mk)
> PID 21633 on the chain.
> Live child 0x564ec1768740 (../scripts/nmk/scripts/scripts/include.mk)
> PID 21633
> Reaping winning child 0x564ec1768740 PID 21633
> Removing child 0x564ec1768740 PID 21633 from chain.

The fix was to remove the extra scripts/, but once I did it, I found
out problem #2: these targets, being defined in contents that is often
included in the beginning of Makefiles, hijacks the default make
target (the first one in the Makefile), breaking the usual and
expected make behavior, and forcing to use .DEFAULT_GOAL.

Finally, I don't know why these targets are there, i.e. what purpose
do they serve. Maybe it was done to exclude any implicit rules to
re-make those files, but there are no such rules as far as I can see.

So, in order to address problem #2, I have removed these targets.
I don't see any harm in doing that; let me know if it breaks anything.

Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@virtuozzo.com>

16790 of 26152 relevant lines covered (64.2%)

91482.86 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
82
69.94
 -8.8% criu/shmem.c
192
70.94
 -0.42% criu/parasite-syscall.c
Jobs
ID Job ID Ran Files Coverage
1 557.1 (TR_ARCH=local) 121
64.2
 Travis Job 557.1
2 557.2 (TR_ARCH=x86_64) 0
Travis Job 557.2
3 557.3 (TR_ARCH=armv7hf) 0
Travis Job 557.3
4 557.4 (TR_ARCH=aarch64) 0
Travis Job 557.4
5 557.5 (TR_ARCH=ppc64le) 0
Travis Job 557.5
6 557.6 (TR_ARCH=alpine) 0
Travis Job 557.6
Source Files on build 557
Coverage ∆ File Lines Relevant Covered Missed Hits/Line