raystack / frontier / 30536703296

47%

main: 47%

Build Type

Pull #1827

github

Committed by whoAbhishekSah

Commit Message

refactor(membership): deduplicate repeated patterns

Behavior unchanged; call sites and public signatures stay the same.

- One resourcePolicyFilter builds resource-scoped policy filters;
  the duplicate policyFilterForResource is gone. removeAllPolicies now
  goes through it and reuses removePoliciesByFilter, so its filter also
  pins resource_type (redundant with the per-type ID fields in SQL).
- validateOrgRole/validateProjectRole/validateGroupRole are one-line
  wrappers over a shared validateRoleForScope.
- validateMinOwnerConstraint/validateMinGroupOwnerConstraint are
  wrappers over a shared validateMinRoleConstraint.
- The five near-identical org/group audit helpers delegate to one
  auditMemberChange that writes both audit stores.
- hasExactlyRole names the repeated "already has exactly this role"
  check.
- principalKey struct replaces the \x00-joined string map keys, and
  ListPrincipalsByResource's role enrichment moves into its own
  function.
- listOrgsForPrincipal/listGroupsForPrincipal reuse policyResourceIDs
  instead of hand-rolled pluck loops.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #1827: refactor(membership): deduplicate repeated patterns

Coverage Stats

146 of 158 new or added lines in 6 files covered. (92.41%)

1 existing line in 1 file now uncovered.

18242 of 38821 relevant lines covered (46.99%)

14.58 hits per line