cpputest / cpputest / 30526865577

99%

push

github

Fix unsigned underflow in SimpleString::subString() on empty strings

subString(beginPos, amount) rejected out-of-range beginPos with
`if (beginPos > size()-1) return "";`. Since size() returns size_t,
calling this on an empty string (size() == 0) makes size()-1 wrap
around to SIZE_MAX, so the bounds check is defeated for any beginPos
and the function falls through to an out-of-bounds read of the
string's internal buffer.

Use `beginPos >= size()` instead, which is mathematically equivalent
to the original check for every size() >= 1 and additionally handles
size() == 0 correctly.

1 of 1 new or added line in 1 file covered. (100.0%)

6765 of 6814 relevant lines covered (99.28%)

46701.83 hits per line