AfterShip / clickhouse-sql-parser / 30525248824

55%

master: 55%

Build Type

Pull #293

github

Committed by therealpandey

Commit Message

Leave a non-join GLOBAL/LOCAL where it was found

parseJoinLocality consumed the keyword before it knew a join followed, so
a locality with no join was swallowed: `SELECT * FROM t1 GLOBAL` parsed and
Format() returned `SELECT * FROM t1`. ClickHouse rejects that (Code 62), as
it does `FROM t global` — GLOBAL is not an implicit alias. Rewind to the
keyword instead, so the statement parser reports it.

The ARRAY JOIN error now points at the locality it names rather than at the
token the join op stopped on, "expected IN after GLOBAL" prints the token
instead of its kind, and parseJoinLocality drops a pos parameter that
parseJoinOp discards.

No golden fixture changes.

Pull Request Pull Request #293: Fix parsing of the GLOBAL/LOCAL join locality and GLOBAL NOT IN

Coverage Stats

52 of 56 new or added lines in 3 files covered. (92.86%)

521 existing lines in 3 files now uncovered.

9132 of 16633 relevant lines covered (54.9%)

3156.02 hits per line