valkyrjaio / valkyrja-ts / 30513641802

100%

push

github

[Workflow] ci: Run the full suite on pull request edits (#104)

# Description

Removes the `changes.base` guard added in the previous CI trigger
change, keeping the `edited`
activity type. Every pull request edit now re-runs the full suite.

## Why the guard had to go

The guard was `if: github.event.action != 'edited' ||
github.event.changes.base` on each tool job, so
a title or description edit would skip them instead of replaying the
matrix. It does not work, and it
breaks merging.

When a caller job that `uses:` a reusable workflow is skipped, the
reusable workflow never runs, so
the `<job> / <job>` context the required status checks are waiting for
is **never produced**. GitHub
evaluates requirements against the **latest run** of the workflow, so an
earlier run's success does
not carry over — it stays visible in the check-runs API but stops
counting. Confirmed on a live pull
request: after a description edit, three runs existed on one unchanged
head SHA and the pull request
showed

```
golangci-lint / golangci-lint   Expected — Waiting for status to be reported   Required
Test / Test                     Expected — Waiting for status to be reported   Required
golangci-lint                   Skipped
Test                            Skipped
```

Note the names: the skip reports the bare caller name (`Test`), not the
required context
(`Test / Test`). So the requirement is simply absent, and the pull
request is blocked until someone
pushes a commit.

## Why `edited` stays

A retargeted pull request must be re-verified, not just unblocked.
Checks that passed against the old
base parent say nothing about `26.x` or `master` — the merge result is
different. Re-running the suite
against the new base is the point of reacting to the retarget at all.

The cost is that a reworded title or description also re-runs
everything. That is accepted
deliberately; the reasoning is recorded in a comment in the trigger
block so the guard is not
reintroduced later.

## Typ... (continued)

1592 of 1592 branches covered (100.0%)

Branch coverage included in aggregate %.

3476 of 3476 relevant lines covered (100.0%)

29.15 hits per line