valkyrjaio / valkyrja-php / 30512663903
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 1138
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30512663903

push

github

web-flow 
[Workflow] ci: Rerun checks when a pull request is edited or retargeted (#956)

# Description

Applies the CI trigger change from

[valkyrjaio/.github#170](https://github.com/valkyrjaio/.github/pull/170)
to this repository.

When a stacked pull request's parent merges, GitHub auto-retargets the
child's base branch — and the
child then sits with **no checks at all**. It happened twice recently,
on `sindri-java#67` and
`valkyrja-starter-app-java#64`: both retargeted to `26.x` and showed
only the third-party SonarCloud
status, because nothing in CI had run. Each needed a manual force-push
to come unstuck.

The cause is an activity-type gap. `pull_request` has no activity type
for a base-branch change;
GitHub reports it as `edited`, with the previous base in a
`changes.base` payload. `ci.yml` declares
`pull_request` with no `types:`, so it gets the defaults — `opened`,
`synchronize`, `reopened` — and
`edited` is not among them, so nothing CI listens for ever fires.

#170 fixed the canonical templates in `required-workflows/`, but that
does not reach any existing
repository: `_ensure-workflows.yml` merges CI **jobs** — it appends job
blocks a repo is missing and
exits without changes when none are missing — and never touches the
`on:` block. So the same edit has
to be made in each repo's own `ci.yml`. This is that edit.

## The change

`edited` is added to the trigger, and the jobs are split by what should
react to it:

- **`commit-message-check` and `trailing-newline-check` run on every
edit.** They already carry
`if: github.event_name == 'pull_request'` and are left untouched, so
they now also fire on `edited`.
That is wanted: the commit-message check validates the **pull request
title**, which is exactly what
an edit changes, so a title corrected to satisfy the convention
re-verifies immediately instead of
  waiting for an unrelated push.
- **Every tool job additionally requires a base change.** `edited` is a
single activity type covering
base, title *a... (continued)

12596 of 12596 relevant lines covered (100.0%)

23.76 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30512663903.1 1138
100.0
 GitHub Action Run
Source Files on build 30512663903