decentraland / builder / 30510905458

52%

master: 52%

Build Type

Pull #3454

github

Committed by decentraland-bot

Commit Message

fix: address review findings — break circular import, harden applyPose, skip redundant Three.js load

- Move thumbnail constants (THUMBNAIL_WIDTH/HEIGHT), THUMBNAIL_POSE_BY_CATEGORY,
  getThumbnailType, and getThumbnailRenderOptions to lib/thumbnailOptions.ts to
  break the lib↔component circular dependency. utils.ts re-exports for backward
  compatibility.
- Tighten getThumbnailRenderOptions return type from Partial<Options> to Options.
- Add POSE_PROPERTIES allowlist in applyPose() to restrict dynamic property
  assignment to position/rotationQuaternion/rotation/scaling.
- Call getScreenshot() directly in getItemData() instead of going through
  getModelData(), which was loading the model via Three.js only to discard the
  metrics.
- Add unit tests for getThumbnailType, THUMBNAIL_POSE_BY_CATEGORY, and
  getThumbnailRenderOptions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Pull Request Pull Request #3454: feat: pose wearables for auto-generated thumbnails by category

Coverage Stats

2316 of 5588 branches covered (41.45%)

Branch coverage included in aggregate %.

15 of 47 new or added lines in 4 files covered. (31.91%)

197 existing lines in 3 files now uncovered.

7292 of 12755 relevant lines covered (57.17%)

34.48 hits per line