ben-manes / caffeine / #5697

100%

push

github

Fix minor defects found by an audit sweep

Resizing the maximum restores the regions to their initial split, which
restarts the adaption, but the climber kept the hit rate it had measured
against the prior geometry along with any transfer it had not yet
finished. The next sample was judged against a baseline that no longer
described the cache, and a pending transfer was applied to regions that
had just been resized.

A Guava loader may not return null, while a Caffeine loader uses it to
say that the key has no value, so a facade decorating the latter under
the former must choose. It returned the null, leaving the caller a
puzzling dereference later on, although getAll on that same cache
already rejected it and every other bridge between the two loaders
converts it. It now rejects it too.

4208 of 4217 branches covered (99.79%)

11 of 11 new or added lines in 3 files covered. (100.0%)

8489 of 8490 relevant lines covered (99.99%)

1.0 hits per line