valkyrjaio / valkyrja-ts / 30509104269

100%

push

github

[CI] Fail the Vitest run below 100% coverage (#102)

# Description

Coverage was reported here and enforced nowhere.
`.github/ci/vitest/vitest.config.ts` had a
`coverage` block with a provider and reporters but no `thresholds`, so
`vitest-coverage` printed the
numbers and exited 0 regardless — a run at 55% passed exactly like one
at 100%. The only thing that
noticed a drop was Coveralls, *after* push, on an already-open PR.

The architecture guide's definition of done is 100% line **and** branch,
per file, and "must never
drop". Nothing in the gate made that true. This adds the assertion:

```ts
thresholds : {
    lines      : 100,
    branches   : 100,
    functions  : 100,
    statements : 100,
},
```

Vitest fails the run natively, so no extra tooling is needed.

## Why an exact 100% floor rather than a percentage

A floor set below 100% does not catch the case that matters. One
fully-uncovered new file barely
moves a repo-wide percentage — adding a single uncovered two-line
function here drops statements only
from 100% to **99.97%**, which any "95%" or even "99%" gate waves
through. At exactly 100% it fails:

```
Statements   : 99.97% ( 3511/3512 )
Branches     : 99.87% ( 1592/1594 )
ERROR: Coverage for lines (99.97%) does not meet global threshold (100%)
ERROR: Coverage for branches (99.87%) does not meet global threshold (100%)
```

That is also why no threshold was lowered to accommodate anything: a
floor of "whatever we happen to
be at" legitimizes the gap it accommodates.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`.github/ci/vitest/vitest.config.ts`** — adds a
`coverage.thres... (continued)

1592 of 1592 branches covered (100.0%)

Branch coverage included in aggregate %.

3476 of 3476 relevant lines covered (100.0%)

29.15 hits per line