valkyrjaio / sindri-java / 30509050255

100%

push

github

[Grpc] Cover the gRPC service-name member loop exit branch (#66)

# Description

`GrpcRouteAttributeReader` sat at 99.84% branch coverage on `26.x` — one
uncovered branch, at the
member loop in `readServiceName`:

```java
for (MemberValuePair pair : normal.getPairs()) {
    if (pair.getNameAsString().equals("service")) {
        return requireStringLiteral(...);
    }
}
```

The loop's **exit** branch was never taken. Every existing fixture
either carries a real `service`
member — which returns from *inside* the loop, so the `hasNext` check
never reports exhaustion — or
uses a marker `@Service`, which fails the `instanceof
NormalAnnotationExpr` guard and never enters
the loop at all. Reaching the exit requires the one shape no fixture
had: a `@Service` that *is* a
normal annotation and *does* carry members, none of them named
`service`.

This is the last branch standing between the repo and 100% line + branch
coverage, which the
architecture guide's definition of done requires. It is being closed
ahead of a follow-up PR that
wires `jacocoCoverageVerification` into the `ci` task, so that gate can
be turned on at 100%
without failing on a pre-existing gap.

The behavior under test is already correct — a `@Service` with no
`service` member is treated as
absent, so the controller contributes no routes. This PR only adds the
fixture and assertion that
prove it.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

-
**`Fixtures/Grpc/Controller/TestUnrelatedServiceMemberGrpcControllerFixture.java`**
— new AST
input sample: a `@Service(name = "pkg.Unrelated")` carrying a member
that is not `service`, so the... (continued)

618 of 618 branches covered (100.0%)

Branch coverage included in aggregate %.

1679 of 1679 relevant lines covered (100.0%)

4.39 hits per line