valkyrjaio / valkyrja-starter-app-java / 30509046264

100%

push

github

[Cli] Cover the untested app providers and gRPC data stubs (#63)

# Description

`.github/ci/junit` was at 94.6% line / 90.9% branch on `26.x` — 16
uncovered lines and 2 uncovered
branches. None of them are stub artifacts of `copy-example-sources`;
every one is ordinary
application code that simply has no test. Checked file by file:

- **The `grpc` data stubs had no tests at all.** `cli` and `http` each
ship an `AppContainerDataTest`
and an `AppEventDataTest`; the `grpc` module, added later, only ever got
  `AppGrpcRoutingDataTest`. That accounts for 6 of the 16 lines.
- **`publishRoutingPermutationsCommand` /
`publishRoutingPermutationsController` were never
called.** Both `ServiceProvider`s test only their *first* publisher
(`publishTestCommand`,
`publishHomeController`), leaving the second one's body — 4 lines each —
unexecuted.
- **`getGrpcProviders` was never called.**
`ComponentProviderTest.exposesAllProviderLists` asserts
the component, container, event, CLI and HTTP provider lists but not the
gRPC one, in both the
  `cli` and `http` modules.
- **Two `CliRouteProvider` option branches.** Every existing handler
assertion runs against a route
that binds *no* options, so `hasOption()` only ever returned `false` and
`permutationsOptionDefaultValueHandler` only ever took its fallback arm.
A second route that does
  bind them takes the other side of both.

This is being closed ahead of a follow-up PR that wires
`jacocoCoverageVerification` into the `ci`
task, so that gate can be turned on at 100% without failing on a
pre-existing gap.

No production code changed — these are tests for behavior that already
works.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
fun... (continued)

22 of 22 branches covered (100.0%)

Branch coverage included in aggregate %.

295 of 295 relevant lines covered (100.0%)

4.83 hits per line