valkyrjaio / valkyrja-starter-app-php / 30509040130
100%

DEFAULT BRANCH: 26.x
Ran
Jobs 1
Files 33
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
30509040130

push

github

web-flow 
[Cli] Cover the absent-option and default-server branches (#185)

# Description

Three uncovered branches on `26.x`, all the same shape: a two-armed
ternary where only one arm was
ever executed. Lines were already at 100%, which is exactly why these
went unnoticed — the lines run
either way, so only branch coverage sees them.

- **`RoutingPermutationsCommand::optionRequiredNone`** — `$isProvided ?
'yes' : 'no'` was only ever
called with `true`. Its siblings `optionNone` and `optionShort` each
already have a "given" *and* an
"absent" case in the data provider; this one was missing its absent
case.
- **`OpenSwooleApp::getSwooleServer`** — `$host !== false ? … :
'127.0.0.1'` and
`$port !== false ? … : 9501`. The existing test sets both environment
variables, so the documented
  default host and port were never exercised.

The behavior under test is already correct; these only add the missing
assertions. No production code
changed.

## Types of changes

- [x] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`RoutingPermutationsCommandTest.php`** — adds an `option required
none absent` provider case
calling `optionRequiredNone(false)`. The longer key pushes the array's
`=>` alignment out one
column, so PHP-CS-Fixer realigned the surrounding entries; that part of
the diff is whitespace
  only.
- **`OpenSwooleAppTest.php`** — adds
`testGetSwooleServerFallsBackToDefaultHostAndPort`, which
unsets both variables and asserts the server binds `127.0.0.1:9501`. It
sits in the existing
`#[RunTestsInSeparateProcesses]` class, so it gets its own process and
does not collide with the
  other test's server (OpenSwoole permits one per pr... (continued)

517 of 517 relevant lines covered (100.0%)

2.12 hits per line

Jobs
ID Job ID Ran Files Coverage
1 30509040130.1 33
100.0
 GitHub Action Run
Source Files on build 30509040130