gregschmit / rails-rest-framework / 30496619839

95%

master: 95%

Build Type

Pull #40

github

Committed by gregschmit

Commit Message

Preserve propagated class-attribute values after local set.

A `propagate { self.x = ... }` followed by a plain `self.x = ...`
clobbered the propagated getter, since both were defined on the same
singleton class. Descendants then had no `super` to reach and fell back
to the default instead of the propagated value.

Store propagated values (and the default baseline) in a per-class module
included in the singleton class, keeping local assignments on the
singleton class itself. A local getter now supers into the module rather
than overwriting it, and descendants keep inheriting the propagated
value. `super` resolves dynamically, so a propagate that happens after an
earlier local override still reaches descendants.

Strengthen the regression test to assert the descendant still sees the
propagated value, not merely that it differs from the local one.

Pull Request Pull Request #40: v2

Coverage Stats

209 of 214 new or added lines in 8 files covered. (97.66%)

1 existing line in 1 file now uncovered.

1222 of 1296 relevant lines covered (94.29%)

335.93 hits per line