FlexMeasures / flexmeasures / 30494267536

83%

main: 83%

Build Type

Pull #2367

github

Committed by Flix6x

Commit Message

fix: keep session vars as strings, make filter_by_belief_time public (round-5 findings)

- The previous round's request.values-merge fix for set_session_variables
  stored deserialized datetime objects in the session for the canonical
  start/end params, whereas downstream template rendering
  (render_flexmeasures_template) only normalizes URL encoding for `str`
  values -- this would have broken query-string reconstruction in the UI.
  Reverted that approach; set_session_variables now takes an `aliases`
  dict so it can check a canonical query key when the legacy one is
  absent, staying entirely at the raw-string level.
- _filter_by_belief_time (flexmeasures/data/queries/annotations.py) is
  imported and used cross-module from data/models/time_series.py and
  data/models/user.py, which contradicts its leading-underscore
  "module-private" signal. Renamed to the public filter_by_belief_time.

Signed-off-by: F.N. Claessen <claessen@seita.nl>

Pull Request Pull Request #2367: fix: let annotation searches filter by belief time

Coverage Stats

94 of 99 new or added lines in 8 files covered. (94.95%)

1 existing line in 1 file now uncovered.

16153 of 19445 relevant lines covered (83.07%)

0.83 hits per line