dangernoodle-io / breadboard / 30493450181

97%

push

github

fix: compose bb_wifi_ensure_net_stack in early tier so blank-NVS boards don't crash-loop (#1135)

- mark bb_wifi_ensure_net_stack with // bbtool:init tier=early
  fn=bb_wifi_ensure_net_stack provides=net_stack (no requires=), so codegen
  composes it with in-degree 0, strictly before bb_wifi_autoinit
  (requires=storage_nvs) in the same tier -- provides=net_stack makes the
  ordering a contract instead of incidental scan-order luck
- on a blank-NVS board, bb_wifi_autoinit previously early-returned at its
  creds gate without bringing up esp_netif/the event loop, so the pre_http
  tier's bb_http_autostart_init -> httpd_start -> socket() hit LWIP's
  "tcpip_send_msg_wait_sem (Invalid mbox)" assert and reboot-looped
  (B1-973); bb_wifi_ensure_net_stack is idempotent, so composing it
  unconditionally is safe for every board
- no consumer declares requires=net_stack: requires= emits a hard
  bb_app_avail_* availability guard (commands.wire._guard_requires), so
  gating e.g. bb_http_autostart_init on it would make httpd conditional on
  bb_wifi being composed at all -- a worse defect than the one being fixed;
  verified via the regenerated smoke composition (bb_http_autostart_init
  still called unconditionally, no bb_app_avail_net_stack emitted since
  nothing requires= it)
- note on bb_wifi_ensure_net_stack (header + espidf definition) that it
  must stay NVS-independent, since it now sorts before
  bb_storage_nvs_register() in the early tier
- add a regression test (synthetic + real-repo integration) asserting
  bb_wifi_ensure_net_stack is composed before bb_wifi_autoinit in the
  early tier, and that its marker declares provides=net_stack

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

7920 of 8524 branches covered (92.91%)

Branch coverage included in aggregate %.

13482 of 13637 relevant lines covered (98.86%)

2610.22 hits per line